Semantic Diff

#9097 Fail the Semantic Diff check for commits without a description

3 commits

83f5eea42685d87e144a44ac486ddd66b3edc873..pr-9097

2218c1c92 · cknitt + Claude · Oct 28, 2026, 13:40 UTC

Fail the Semantic Diff check for commits without a description

Commits with only a subject, like #9075's, leave their Semantic Diff cards empty. The records format already requires a description; commitRecords.js --check now enforces it after the comment is drawn, and CONTRIBUTING.md, the PR template and AGENTS.md say so.

addedDiagnostic commit without a description

text
After
A commit has no description:   a1bc9e110 Add missing JSX DOM event bindings Below its subject, a commit message says why the commit is made, as a lineor two of prose or a `Why:` section (see "Commit messages" inCONTRIBUTING.md). Add one with `git rebase -i`, marking these commits`reword`, or squash them into a commit that has one, and force-push.

Review

  • What counts as a description? A paragraph of prose, or a Why: section with content. Object blocks, code and trailers alone don't count.
4da09b6d9 · cknitt + Claude · Oct 28, 2026, 13:50 UTC

Leave the check command out of the records skill

The skill already requires a description, and the failing check explains itself, so naming the script there adds nothing.

c494d71ed · cknitt + Claude · Oct 28, 2026, 13:50 UTC

List the commit description before the sign-off in the PR template

The checklist now follows the order of a commit message: the description comes before the Signed-off-by trailer.