#8919 Keep attributes in front of a record or open type representation

The parser accepts attributes and doc comments between = and a record declaration or .. (since #7787) but threw them away. They now go on the type declaration, after its leading attributes, so PPXs and the type checker see them; the formatter prints them in front of type. The attributed path also passes the inline-record context on, so nested record types inside such a record parse.

Example ReScript

@schematype t = @s.strict {  email: string,  name: string,}type u = @attr {x: {y: int}}

@schematype t = {  email: string,  name: string,}// type u: "An inline record type declaration is only allowed in a// variant constructor's declaration or nested inside of a record type// declaration"

@schema @s.stricttype t = {  email: string,  name: string,}@attr type u = {x: {y: int}}

Review

• Why the declaration and not an error? The issue asks for the attribute to reach the PPX, and the declaration is the only parsetree node a record or open type kind has. An attribute in front of a constructor still attaches to that constructor.

No effect

Output: unchangedFormats: nonePPX: unchangedEditor: unchanged

Formatting

changedtype t = @a {...} and type t = @a .. now print as @a type t = ... instead of dropping @a

Tests

syntax tests/syntax_tests/data/~ parsing/grammar/typedefinition/typeRepresentation.res~ parsing/grammar/typedefinition/expected/typeRepresentation.res.txt~ parsing/grammar/typedefinition/expected/recordDeclaration.res.txt~ printer/typeDef/attributes.res~ printer/typeDef/expected/attributes.res.txt

• Changelog fragment changes/type-representation-attributes.fix.md
• No committed generated JS changes

A doc comment directly after = now goes through the same lookahead as an attribute: in front of { or .. it attaches to the type declaration, in front of a constructor it still attaches to that constructor. Before, only a doc comment after an attribute reached the declaration; one at the start was parsed as a constructor list and failed on { or ...

Example ReScript

type t = /** doc */ {x: int}type u = /** doc */ ..

Before output

syntax errors: a constructor is expected at `{` and at `..`

After ReScript

/** doc */type t = {x: int}/** doc */type u = ..

No effect

Output: unchangedFormats: nonePPX: unchangedEditor: unchanged

Formatting

changedtype t = /** doc */ {...} and type t = /** doc */ .. now parse and print with the doc comment in front of type

Tests

syntax tests/syntax_tests/data/~ parsing/grammar/typedefinition/typeRepresentation.res~ parsing/grammar/typedefinition/expected/typeRepresentation.res.txt~ printer/typeDef/attributes.res~ printer/typeDef/expected/attributes.res.txt

• No committed generated JS changes